Remove CFA discriminant check restrictions #36114
Conversation
|
@typescript-bot test this |
|
Heya @ahejlsberg, I've started to run the extended test suite on this PR at 766cb83. You can monitor the build here. It should now contribute to this PR's status checks. |
|
Heya @ahejlsberg, I've started to run the parallelized community code test suite on this PR at 766cb83. You can monitor the build here. It should now contribute to this PR's status checks. |
|
Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 766cb83. You can monitor the build here. It should now contribute to this PR's status checks. |
|
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
|
Tests look clean. All failures are preexisting conditions. |
* Remove unnecessary containsMatchingReferenceDiscriminant logic * Accept new baselines
In #10028 we added logic to reset control flow analysis based types following discriminant checks. This logic was really only needed in scenarios involving loops, and it now appears unnecessary, likely because of subsequent fixes in loop analysis that addressed the root issue.
Having thought about it some more, I can't come up with any examples that merit the code added in ade89a6, and removing it has no longer has adverse effects.
Fixes #36028.